Rollup of 9 pull requests #136227

fmease · 2025-01-29T05:03:26Z

Successful merges:

Deduplicate operand creation between scalars, non-scalars and string patterns #136121 (Deduplicate operand creation between scalars, non-scalars and string patterns)
Fix SIMD codegen tests on LLVM 20 #136134 (Fix SIMD codegen tests on LLVM 20)
Locate asan-odr-win with other sanitizer tests #136153 (Locate asan-odr-win with other sanitizer tests)
rustdoc: add nobuild typescript checking to our JS #136161 (rustdoc: add nobuild typescript checking to our JS)
interpret: is_alloc_live: check global allocs last #136166 (interpret: is_alloc_live: check global allocs last)
GCI: Don't try to eval / collect mono items inside overly generic free const items #136168 (GCI: Don't try to eval / collect mono items inside overly generic free const items)
Reject unsound toggling of Arm atomics-32 target feature #136170 (Reject unsound toggling of Arm atomics-32 target feature)
Render pattern types nicely in mir dumps #136176 (Render pattern types nicely in mir dumps)
uefi: process: Fix args #136186 (uefi: process: Fix args)

r? @ghost
@rustbot modify labels: rollup

…patterns

The splat contents are printed differently on LLVM 20.

By nobuild, I mean that the type annotations are all in comments, not in the "native" typescript syntax. This is a bit uglier, but it lets you rapid-prototype without tsc, works with all the native browser debugging tools, and keeps Node out of Rust's bootstrap chain. This pull request mostly just adds ts-ignore annotations and type declarations. To actually take good advantage of typescript, we'll want to "burn down" this pile of unsafe code until we eventually have a version with almost none of these. This PR also adds tsc to the mingw-check Dockerfile, so that it can't fall out of date like the Closure annotations did. https://rust-lang.zulipchat.com/#narrow/channel/266220-t-rustdoc/topic/typescript

… items

- While working on process env support, I found that args were currently broken. Not sure how I missed it in the PR, but well here is the fix. - Additionally, no point in adding space at the end of args. Signed-off-by: Ayush Singh <ayush@beagleboard.org>

Deduplicate operand creation between scalars, non-scalars and string patterns just something that felt duplicated and would make pattern type handling a bit more roundabout.

Fix SIMD codegen tests on LLVM 20 The splat constants are printed differently on LLVM 20.

Locate asan-odr-win with other sanitizer tests

…omez rustdoc: add nobuild typescript checking to our JS By nobuild, I mean that the type annotations are all [in comments], not in the "native" typescript syntax. This is a bit uglier, but it lets you rapid-prototype without tsc, works with all the native browser debugging tools, and keeps Node out of Rust's bootstrap chain. [in comments]: https://news.ycombinator.com/item?id=35892250 This pull request mostly just adds ts-ignore annotations and type declarations. To actually take good advantage of typescript, we'll want to "burn down" this pile of unsafe code until we eventually have a version with almost none of these. This PR also adds tsc to the mingw-check Dockerfile, so that it can't fall out of date like the Closure annotations did. https://rust-lang.zulipchat.com/#narrow/channel/266220-t-rustdoc/topic/typescript r? `@GuillaumeGomez` `@lolbinarycat`

…=compiler-errors interpret: is_alloc_live: check global allocs last See rust-lang#136105 (comment). (A perf run makes no sense as this is only used by Miri.)

…rors GCI: Don't try to eval / collect mono items inside overly generic free const items Fixes rust-lang#136156. Thanks for the pointers, errs! There's one (preexisting) thing of note (maybe?). There's a difference between `const _: () = panic!();` and `const _<'a>: () = panic!();`: The former is a pre-mono error, the latter is a post-mono error. For comparison, both `fn _f() { const { panic!() } }` and `fn _f<'a: 'a>() { const { panic!() } }` are post-mono errors. cc `@oli-obk` r? compiler-errors or reassign

Reject unsound toggling of Arm atomics-32 target feature This target feature has the same semantics as RISC-V `forced-atomics` target feature that already marked as Forbidden (llvm/llvm-project@f5ed0cb) and toggling it can cause ABI incompatibility. https://github.com/rust-lang/rust/blob/2f348cb7ce4063fa4eb40038e6ada3c5214717bd/compiler/rustc_target/src/target_features.rs#L479-L483 [Comment on feature definition in LLVM](https://github.com/llvm/llvm-project/blob/7109f521975e9cc2e8ba4f52ac2a8e1140bd49b5/llvm/lib/Target/ARM/ARMFeatures.td#L572-L574) also says: > Code built with this feature is not ABI-compatible with code built without this feature, if atomic variables are exposed across the ABI boundary. r? `@workingjubilee` or `@RalfJung` `@rustbot` label +O-Arm

…ompiler-errors Render pattern types nicely in mir dumps avoid falling through to the fallback rendering that just does a hex dump r? ``@scottmcm`` best reviewed commit by commit

…=nicholasbishop,Noratrieb uefi: process: Fix args - While working on process env support, I found that args were currently broken. Not sure how I missed it in the PR, but well here is the fix. - Additionally, no point in adding space at the end of args.

fmease · 2025-01-29T05:03:38Z

@bors r+ rollup=never p=5

matthiaskrgr · 2025-01-29T08:59:07Z

@bors retry

bors · 2025-01-29T11:27:22Z

⌛ Testing commit 7e60f27 with merge a1d7676...

bors · 2025-01-29T14:33:23Z

☀️ Test successful - checks-actions
Approved by: fmease
Pushing a1d7676 to master...

rust-timer · 2025-01-29T14:36:00Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#136121	Deduplicate operand creation between scalars, non-scalars a…	`55459160c137c128b747838c1f148869f376b98a` (link)
#136134	Fix SIMD codegen tests on LLVM 20	`c5463a69f4748ef853e5b9945aed766c1ad81496` (link)
#136153	Locate asan-odr-win with other sanitizer tests	`ab534372fa7fd1ca5621c0b9b21ec43c5db995c8` (link)
#136161	rustdoc: add nobuild typescript checking to our JS	`4da3a6b8954ff5cfbafe243d400d10ee98ef18a2` (link)
#136166	interpret: is_alloc_live: check global allocs last	`595a5a36fdf6a305bb8ecb14aa40aea8c91c5a3a` (link)
#136168	GCI: Don't try to eval / collect mono items inside overly g…	`1acc6c087c3e49ba366588e29e736ca5aea3f815` (link)
#136170	Reject unsound toggling of Arm atomics-32 target feature	`e406274d4eec985e8e327d6ef2b8598854aa8e8c` (link)
#136176	Render pattern types nicely in mir dumps	`925cbfb6ee0b7f2d2c40059fd7a6042f511db258` (link)
#136186	uefi: process: Fix args	`8cf2f7fd640c5319e01fd3aa991b183014ed6cd5` (link)

previous master: 61cc3e51f8

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2025-01-29T15:51:28Z

Finished benchmarking commit (a1d7676): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	1
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[0.2%, 0.2%]	1

Max RSS (memory usage)

Results (primary 1.0%, secondary 0.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.0%	[1.0%, 1.0%]	1
Regressions ❌ (secondary)	1.9%	[1.3%, 2.7%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.7%	[-2.3%, -1.1%]	2
All ❌✅ (primary)	1.0%	[1.0%, 1.0%]	1

Cycles

Results (secondary -2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.532s -> 777.437s (0.25%)
Artifact size: 328.40 MiB -> 328.50 MiB (0.03%)

fmease · 2025-01-29T16:03:49Z

All regressions come from the doc profile, so I'm suspecting #136161.

notriddle · 2025-01-29T16:38:35Z

#136253

rylev · 2025-02-04T23:25:14Z

@rust-timer build 4da3a6b

rust-timer · 2025-02-05T01:11:28Z

Finished benchmarking commit (4da3a6b): comparison URL.

Overall result: ❌ regressions - please read the text below

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	1
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	10
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[0.2%, 0.2%]	1

Max RSS (memory usage)

Results (primary -1.0%, secondary -1.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.2%	[1.2%, 1.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.2%	[-3.2%, -3.2%]	1
Improvements ✅ (secondary)	-1.3%	[-1.7%, -1.0%]	2
All ❌✅ (primary)	-1.0%	[-3.2%, 1.2%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.532s -> 776.024s (0.06%)
Artifact size: 328.40 MiB -> 328.42 MiB (0.01%)

rylev · 2025-02-05T03:13:31Z

Fixed by #136253

@rustbot label +perf-regression-triaged

oli-obk and others added 21 commits January 27, 2025 10:24

Deduplicate operand creation between scalars, non-scalars and string …

a9213c2

…patterns

Use an operand instead of a place that is always turned into an operand

e1e2e17

Fix SIMD codegen tests on LLVM 20

f895e31

The splat contents are printed differently on LLVM 20.

Locate asan-odr-win with other sanitizer tests

fa4589b

interpret: is_alloc_live: check global allocs last

bc135aa

GCI: Don't try to collect mono items inside overly generic free const…

0a9ee02

… items

Reject unsound toggling of Arm atomics-32 target feature

7f83f8a

Add mir-opt pattern type tests

7877d86

Make mir dumps more readable

fd6713f

Edit the inputs to const == val check instead of duplicating logic

d62f885

uefi: process: Fix args

9c4fd25

- While working on process env support, I found that args were currently broken. Not sure how I missed it in the PR, but well here is the fix. - Additionally, no point in adding space at the end of args. Signed-off-by: Ayush Singh <ayush@beagleboard.org>

Rollup merge of rust-lang#136121 - oli-obk:push-zzvxlynmnqpp, r=estebank

8d183d2

Deduplicate operand creation between scalars, non-scalars and string patterns just something that felt duplicated and would make pattern type handling a bit more roundabout.

Rollup merge of rust-lang#136134 - nikic:llvm-20-simd-tests, r=Urgau

01f1dab

Fix SIMD codegen tests on LLVM 20 The splat constants are printed differently on LLVM 20.

Rollup merge of rust-lang#136153 - tmiasko:mv-asan-test, r=lqd

dbc204d

Locate asan-odr-win with other sanitizer tests

Rollup merge of rust-lang#136166 - RalfJung:interpet-is-alloc-live, r…

bde47b7

…=compiler-errors interpret: is_alloc_live: check global allocs last See rust-lang#136105 (comment). (A perf run makes no sense as this is only used by Miri.)

Rollup merge of rust-lang#136176 - oli-obk:pattern-type-mir-opts, r=c…

f49ad60

…ompiler-errors Render pattern types nicely in mir dumps avoid falling through to the fallback rendering that just does a hex dump r? ``@scottmcm`` best reviewed commit by commit

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 29, 2025

bors merged commit a1d7676 into rust-lang:master Jan 29, 2025
7 checks passed

rustbot added this to the 1.86.0 milestone Jan 29, 2025

bors mentioned this pull request Jan 29, 2025

rustdoc: use a button instead of a bar for search #133279

Closed

fmease deleted the rollup-ewpvznh branch January 29, 2025 15:29

bors mentioned this pull request Jan 29, 2025

Rework and optimize match MIR generation #136123

Closed

25 tasks

rustbot added the perf-regression Performance regression. label Jan 29, 2025

fmease mentioned this pull request Jan 29, 2025

rustdoc: add nobuild typescript checking to our JS #136161

Merged

This comment has been minimized.

Sign in to view

rustbot added the perf-regression-triaged The performance regression has been triaged. label Feb 5, 2025

Uh oh!

Rollup of 9 pull requests #136227

Rollup of 9 pull requests #136227

Uh oh!

Conversation

fmease commented Jan 29, 2025

Uh oh!

fmease commented Jan 29, 2025

Uh oh!

matthiaskrgr commented Jan 29, 2025

Uh oh!

bors commented Jan 29, 2025

Uh oh!

bors commented Jan 29, 2025

Uh oh!

Uh oh!

rust-timer commented Jan 29, 2025

Uh oh!

rust-timer commented Jan 29, 2025

Overall result: ❌ regressions - please read the text below

Uh oh!

fmease commented Jan 29, 2025

Uh oh!

notriddle commented Jan 29, 2025

Uh oh!

rylev commented Feb 4, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Feb 5, 2025

Overall result: ❌ regressions - please read the text below

Uh oh!

rylev commented Feb 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants