Skip to content

Conversation

@matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

JoJoDeveloping and others added 30 commits November 1, 2024 15:37
also adding the `_SC_PAGESIZE` alias `_SC_PAGE_SIZE` supported by
Linux, macOS and FreeBSD.

close rust-lang#4050
sysconf interception fix for solarish systems.
follow-up on rust-lang#4052, making a miri evaluation context fn for strerror_r.
Refactor AnonSocket::read/write for blocking socketpair
Co-authored-by: Ralf Jung <post@ralfj.de>
Use `PathBuf` APIs to correctly do some path manipulation cross-platform
Simplify thread blocking tests
filesystem support for solarish: stat
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 9, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=7

@bors
Copy link
Collaborator

bors commented Dec 9, 2024

📌 Commit e01cb62 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 9, 2024
@bors
Copy link
Collaborator

bors commented Dec 9, 2024

⌛ Testing commit e01cb62 with merge 1b3fb31...

@bors
Copy link
Collaborator

bors commented Dec 9, 2024

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 1b3fb31 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 9, 2024
@bors bors merged commit 1b3fb31 into rust-lang:master Dec 9, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 9, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#133567 A bunch of cleanups 8b4b61d9728d61a037e0505d36cc79d4b9f4bfc2 (link)
#133789 Add doc alias 'then_with' for then method on bool f834a6a4279715ca82b81dc1576acaa11003dc74 (link)
#133880 Expand home_dir docs 21a1e7d6b126f606facde3c4ae905c3c5729014a (link)
#134036 crash tests: use individual mir opts instead of mir-opt-lev… 139afda6e490769b2449bea9d42f8d28790c9a3c (link)
#134045 Fix some triagebot mentions paths 2a052f16c79754e5716cf12836b77329cb59d1b1 (link)
#134046 Remove ignored tests for hangs w/ new solver d25d6479b171957c3adfa756c69e3ab7119022bb (link)
#134050 Miri subtree update 6f63950c84de0aeb6a4a046107383ea02b9da5bf (link)

previous master: df5b8e39b7

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1b3fb31): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.3%, 0.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -1.3%, secondary 1.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.6% [1.7%, 5.7%] 6
Improvements ✅
(primary)
-1.3% [-1.3%, -1.3%] 1
Improvements ✅
(secondary)
-4.8% [-5.4%, -4.3%] 2
All ❌✅ (primary) -1.3% [-1.3%, -1.3%] 1

Cycles

Results (secondary 3.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.5% [2.8%, 5.5%] 12
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 766.815s -> 769.074s (0.29%)
Artifact size: 330.84 MiB -> 330.87 MiB (0.01%)

@matthiaskrgr matthiaskrgr deleted the rollup-puxwqrk branch January 25, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.