rename lint to ref_clone_in_vec_init

Author: yonip23

CHANGELOG.md

@@ -3434,7 +3434,6 @@ Released 2018-09-13
 [`ifs_same_cond`]: https://rust-lang.github.io/rust-clippy/master/index.html#ifs_same_cond
 [`implicit_clone`]: https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone
 [`implicit_hasher`]: https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
-[`implicit_reference_clone`]: https://rust-lang.github.io/rust-clippy/master/index.html#implicit_reference_clone
 [`implicit_return`]: https://rust-lang.github.io/rust-clippy/master/index.html#implicit_return
 [`implicit_saturating_sub`]: https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub
 [`imprecise_flops`]: https://rust-lang.github.io/rust-clippy/master/index.html#imprecise_flops
@@ -3659,6 +3658,7 @@ Released 2018-09-13
 [`redundant_slicing`]: https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing
 [`redundant_static_lifetimes`]: https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
 [`ref_binding_to_reference`]: https://rust-lang.github.io/rust-clippy/master/index.html#ref_binding_to_reference
+[`ref_clone_in_vec_init`]: https://rust-lang.github.io/rust-clippy/master/index.html#ref_clone_in_vec_init
 [`ref_option_ref`]: https://rust-lang.github.io/rust-clippy/master/index.html#ref_option_ref
 [`regex_macro`]: https://rust-lang.github.io/rust-clippy/master/index.html#regex_macro
 [`repeat_once`]: https://rust-lang.github.io/rust-clippy/master/index.html#repeat_once

clippy_lints/src/lib.register_all.rs

@@ -94,7 +94,6 @@ store.register_group(true, "clippy::all", Some("clippy_all"), vec![
     LintId::of(get_last_with_len::GET_LAST_WITH_LEN),
     LintId::of(identity_op::IDENTITY_OP),
     LintId::of(if_let_mutex::IF_LET_MUTEX),
-    LintId::of(implicit_reference_clone::IMPLICIT_REFERENCE_CLONE),
     LintId::of(indexing_slicing::OUT_OF_BOUNDS_INDEXING),
     LintId::of(infinite_iter::INFINITE_ITER),
     LintId::of(inherent_to_string::INHERENT_TO_STRING),
@@ -269,6 +268,7 @@ store.register_group(true, "clippy::all", Some("clippy_all"), vec![
     LintId::of(redundant_field_names::REDUNDANT_FIELD_NAMES),
     LintId::of(redundant_slicing::REDUNDANT_SLICING),
     LintId::of(redundant_static_lifetimes::REDUNDANT_STATIC_LIFETIMES),
+    LintId::of(ref_clone_in_vec_init::REF_CLONE_IN_VEC_INIT),
     LintId::of(reference::DEREF_ADDROF),
     LintId::of(regex::INVALID_REGEX),
     LintId::of(repeat_once::REPEAT_ONCE),

clippy_lints/src/lib.register_lints.rs

@@ -189,7 +189,6 @@ store.register_lints(&[
     if_not_else::IF_NOT_ELSE,
     if_then_some_else_none::IF_THEN_SOME_ELSE_NONE,
     implicit_hasher::IMPLICIT_HASHER,
-    implicit_reference_clone::IMPLICIT_REFERENCE_CLONE,
     implicit_return::IMPLICIT_RETURN,
     implicit_saturating_sub::IMPLICIT_SATURATING_SUB,
     inconsistent_struct_constructor::INCONSISTENT_STRUCT_CONSTRUCTOR,
@@ -455,6 +454,7 @@ store.register_lints(&[
     redundant_slicing::DEREF_BY_SLICING,
     redundant_slicing::REDUNDANT_SLICING,
     redundant_static_lifetimes::REDUNDANT_STATIC_LIFETIMES,
+    ref_clone_in_vec_init::REF_CLONE_IN_VEC_INIT,
     ref_option_ref::REF_OPTION_REF,
     reference::DEREF_ADDROF,
     regex::INVALID_REGEX,

clippy_lints/src/lib.register_suspicious.rs

@@ -20,13 +20,13 @@ store.register_group(true, "clippy::suspicious", Some("clippy_suspicious"), vec!
     LintId::of(formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING),
     LintId::of(formatting::SUSPICIOUS_ELSE_FORMATTING),
     LintId::of(formatting::SUSPICIOUS_UNARY_OP_FORMATTING),
-    LintId::of(implicit_reference_clone::IMPLICIT_REFERENCE_CLONE),
     LintId::of(loops::EMPTY_LOOP),
     LintId::of(loops::FOR_LOOPS_OVER_FALLIBLES),
     LintId::of(loops::MUT_RANGE_BOUND),
     LintId::of(methods::SUSPICIOUS_MAP),
     LintId::of(mut_key::MUTABLE_KEY_TYPE),
     LintId::of(octal_escapes::OCTAL_ESCAPES),
+    LintId::of(ref_clone_in_vec_init::REF_CLONE_IN_VEC_INIT),
     LintId::of(suspicious_trait_impl::SUSPICIOUS_ARITHMETIC_IMPL),
     LintId::of(suspicious_trait_impl::SUSPICIOUS_OP_ASSIGN_IMPL),
 ])

clippy_lints/src/lib.rs

@@ -247,7 +247,6 @@ mod if_let_mutex;
 mod if_not_else;
 mod if_then_some_else_none;
 mod implicit_hasher;
-mod implicit_reference_clone;
 mod implicit_return;
 mod implicit_saturating_sub;
 mod inconsistent_struct_constructor;
@@ -353,6 +352,7 @@ mod redundant_field_names;
 mod redundant_pub_crate;
 mod redundant_slicing;
 mod redundant_static_lifetimes;
+mod ref_clone_in_vec_init;
 mod ref_option_ref;
 mod reference;
 mod regex;
@@ -891,7 +891,7 @@ pub fn register_plugins(store: &mut rustc_lint::LintStore, sess: &Session, conf:
     let max_include_file_size = conf.max_include_file_size;
     store.register_late_pass(move || Box::new(large_include_file::LargeIncludeFile::new(max_include_file_size)));
     store.register_late_pass(|| Box::new(strings::TrimSplitWhitespace));
-    store.register_late_pass(|| Box::new(implicit_reference_clone::ImplicitReferenceClone));
+    store.register_late_pass(|| Box::new(ref_clone_in_vec_init::RefCloneInVecInit));
     // add lints here, do not remove this comment, it's used in `new_lint`
 }
 

…py_lints/src/implicit_reference_clone.rs clippy_lints/src/ref_clone_in_vec_init.rsclippy_lints/src/implicit_reference_clone.rs renamed to clippy_lints/src/ref_clone_in_vec_init.rs clippy_lints/src/implicit_reference_clone.rs renamed to clippy_lints/src/ref_clone_in_vec_init.rs

@@ -26,13 +26,13 @@ declare_clippy_lint! {
     /// let v = vec![data; 100];
     /// ```
     #[clippy::version = "1.62.0"]
-    pub IMPLICIT_REFERENCE_CLONE,
+    pub REF_CLONE_IN_VEC_INIT,
     suspicious,
     "initializing `Arc` or `Rc` in `vec![elem; len]`"
 }
-declare_lint_pass!(ImplicitReferenceClone => [IMPLICIT_REFERENCE_CLONE]);
+declare_lint_pass!(RefCloneInVecInit => [REF_CLONE_IN_VEC_INIT]);
 
-impl LateLintPass<'_> for ImplicitReferenceClone {
+impl LateLintPass<'_> for RefCloneInVecInit {
     fn check_expr(&mut self, cx: &LateContext<'_>, expr: &Expr<'_>) {
         let Some(macro_call) = root_macro_call_first_node(cx, expr) else { return; };
         let Some(VecArgs::Repeat(elem, _)) = VecArgs::hir(cx, expr) else { return; };
@@ -47,7 +47,7 @@ fn yield_lint(cx: &LateContext<'_>, symbol: Symbol, macro_call: &MacroCall) {
 
     span_lint_and_then(
         cx,
-        IMPLICIT_REFERENCE_CLONE,
+        REF_CLONE_IN_VEC_INIT,
         macro_call.span,
         &format!("calling `{symbol_name}::new` in `vec![elem; len]`"),
         |diag| {

…icit_reference_clone/arc/complex_case.rs …ef_clone_in_vec_init/arc/complex_case.rstests/ui/implicit_reference_clone/arc/complex_case.rs renamed to tests/ui/ref_clone_in_vec_init/arc/complex_case.rs tests/ui/implicit_reference_clone/arc/complex_case.rs renamed to tests/ui/ref_clone_in_vec_init/arc/complex_case.rs

@@ -1,4 +1,4 @@
-#![warn(clippy::implicit_reference_clone)]
+#![warn(clippy::ref_clone_in_vec_init)]
 use std::sync::Mutex;
 
 fn main() {

…_reference_clone/arc/complex_case.stderr …lone_in_vec_init/arc/complex_case.stderrtests/ui/implicit_reference_clone/arc/complex_case.stderr renamed to tests/ui/ref_clone_in_vec_init/arc/complex_case.stderr tests/ui/implicit_reference_clone/arc/complex_case.stderr renamed to tests/ui/ref_clone_in_vec_init/arc/complex_case.stderr

@@ -11,7 +11,7 @@ LL | |         2
 LL | |     ];
    | |_____^
    |
-   = note: `-D clippy::implicit-reference-clone` implied by `-D warnings`
+   = note: `-D clippy::ref-clone-in-vec-init` implied by `-D warnings`
    = note: each `Arc` will point to the same allocation
    = help: if this is intentional, consider extracting the `Arc` initialization to a variable
 

…eference_clone/arc/custom_arc_strucrt.rs …ne_in_vec_init/arc/custom_arc_strucrt.rstests/ui/implicit_reference_clone/arc/custom_arc_strucrt.rs renamed to tests/ui/ref_clone_in_vec_init/arc/custom_arc_strucrt.rs tests/ui/implicit_reference_clone/arc/custom_arc_strucrt.rs renamed to tests/ui/ref_clone_in_vec_init/arc/custom_arc_strucrt.rs

@@ -1,4 +1,4 @@
-#![warn(clippy::implicit_reference_clone)]
+#![warn(clippy::ref_clone_in_vec_init)]
 
 #[derive(Clone)]
 struct Arc;

…licit_reference_clone/arc/simple_case.rs …ref_clone_in_vec_init/arc/simple_case.rstests/ui/implicit_reference_clone/arc/simple_case.rs renamed to tests/ui/ref_clone_in_vec_init/arc/simple_case.rs tests/ui/implicit_reference_clone/arc/simple_case.rs renamed to tests/ui/ref_clone_in_vec_init/arc/simple_case.rs

@@ -1,4 +1,4 @@
-#![warn(clippy::implicit_reference_clone)]
+#![warn(clippy::ref_clone_in_vec_init)]
 use std::sync::Arc;
 
 fn main() {