simplify

Author: yonip23

clippy_lints/src/implicit_reference_clone.rs

@@ -35,12 +35,10 @@ declare_lint_pass!(ImplicitReferenceClone => [IMPLICIT_REFERENCE_CLONE]);
 impl LateLintPass<'_> for ImplicitReferenceClone {
     fn check_expr(&mut self, cx: &LateContext<'_>, expr: &Expr<'_>) {
         let Some(macro_call) = root_macro_call_first_node(cx, expr) else { return; };
+        let Some(VecArgs::Repeat(elem, _)) = VecArgs::hir(cx, expr) else { return; };
+        let Some(symbol) = new_reference_call(cx, elem) else { return; };
 
-        if let Some(VecArgs::Repeat(elem, _)) = VecArgs::hir(cx, expr) {
-            let Some(symbol) = new_reference_call(cx, elem) else { return; };
-
-            yield_lint(cx, symbol, &macro_call);
-        }
+        yield_lint(cx, symbol, &macro_call);
     }
 }
 
@@ -71,10 +69,7 @@ fn new_reference_call(cx: &LateContext<'_>, expr: &Expr<'_>) -> Option<Symbol> {
         if last_path_segment(func_path).ident.name == sym::new;
 
         then {
-            return match cx.tcx.get_diagnostic_name(def_id) {
-                Some(symbol) if symbol == sym::Arc || symbol == sym::Rc => Some(symbol),
-                _ => None
-            };
+            return cx.tcx.get_diagnostic_name(def_id).filter(|symbol| symbol == &sym::Arc || symbol == &sym::Rc);
         }
     }