Fix scoring logic in CompletionRelevance

mustakimali · mustakimali · commit 157fd5dafd86 · 2024-01-05T23:01:57.000Z
diff --git a/crates/ide-completion/src/item.rs b/crates/ide-completion/src/item.rs
@@ -306,7 +306,7 @@ impl CompletionRelevance {
                 // Prefer functions with no arguments, then functions with self arguments
                 if score > 0 {
                     score += if !asf.has_args { 2 } else { 0 };
-                    score -= if asf.has_self_arg { 1 } else { 0 };
+                    score -= if asf.has_self_arg { score - 1 } else { 0 };
                 }
 
                 score

Original file line number	Diff line number	Diff line change
`@@ -306,7 +306,7 @@ impl CompletionRelevance {`
`306`	`306`	`// Prefer functions with no arguments, then functions with self arguments`
`307`	`307`	`if score > 0 {`
`308`	`308`	`score += if !asf.has_args { 2 } else { 0 };`
`309`		`- score -= if asf.has_self_arg { 1 } else { 0 };`
	`309`	`+ score -= if asf.has_self_arg { score - 1 } else { 0 };`
`310`	`310`	`}`
`311`	`311`
`312`	`312`	`score`