no score if return ty Other

Author: mustakimali

crates/ide-completion/src/item.rs

@@ -304,8 +304,10 @@ impl CompletionRelevance {
                 };
 
                 // Prefer functions with no arguments, then functions with self arguments
-                score += if !asf.has_args { 2 } else { 0 };
-                score -= if score > 0 && asf.has_self_arg { 1 } else { 0 };
+                if score > 0 {
+                    score += if !asf.has_args { 2 } else { 0 };
+                    score -= if asf.has_self_arg { 1 } else { 0 };
+                }
 
                 score
             })

crates/ide-completion/src/render.rs

@@ -2075,8 +2075,8 @@ fn test() {
                 fn fn_ctr_with_args(…) [type_could_unify]
                 fn fn_builder() [type_could_unify]
                 fn fn_ctr() [type_could_unify]
-                fn fn_other() [type_could_unify]
                 me fn_no_ret(…) [type_could_unify]
+                fn fn_other() [type_could_unify]
             "#]],
         );
 
@@ -2150,8 +2150,8 @@ fn test() {
                 fn fn_builder() [type_could_unify]
                 fn fn_ctr() [type_could_unify]
                 fn fn_ctr2() [type_could_unify]
-                fn fn_other() [type_could_unify]
                 me fn_no_ret(…) [type_could_unify]
+                fn fn_other() [type_could_unify]
             "#]],
         );
 
@@ -2183,8 +2183,8 @@ fn test() {
                 fn fn_builder() []
                 fn fn_ctr() []
                 fn fn_ctr2() []
-                fn fn_other() []
                 me fn_no_ret(…) []
+                fn fn_other() []
             "#]],
         );
     }