Skip to content

Add SOL_LOCAL to FreeBSD-like targets#5185

Open
mansiverma897993 wants to merge 1 commit into
rust-lang:mainfrom
mansiverma897993:feat/add-sol-local-freebsd
Open

Add SOL_LOCAL to FreeBSD-like targets#5185
mansiverma897993 wants to merge 1 commit into
rust-lang:mainfrom
mansiverma897993:feat/add-sol-local-freebsd

Conversation

@mansiverma897993

Copy link
Copy Markdown

Add SOL_LOCAL constant (value 0) to FreeBSD-like targets (FreeBSD and DragonFlyBSD) to match Apple/macOS targets and allow setting local socket options. Also added it to semver test files.

@tgross35

Copy link
Copy Markdown
Contributor

Please add links to the relevant headers in the PR description when adding/changing API (the PR template asks for this).

But this seems fine to me, cc @asomers for FreeBSD

@mansiverma897993

Copy link
Copy Markdown
Author

@tgross35
Issue #5168
Fix by #5185 and I will remind it for next time for sure !! (Relevant headers )

@tgross35

Copy link
Copy Markdown
Contributor

You can edit the description and add that all, including the header links :)

@asomers asomers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find this symbol defined anywhere in DragonflyBSD's man pages or source. So please move the definition into freebsd/mod.rs .

View changes since this review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants