linux(musl): deprecate LFS64 bindings#5170
Conversation
911a9e2 to
348a55e
Compare
This comment has been minimized.
This comment has been minimized.
|
I haven't yet taken a close look here but I think deprecation of |
|
I've double-checked the changes in this patch with upstream. There really isn't a difference between unsuffixed types and suffixed types. musl will just provide 64-bit definitions no matter what. I don't quite understand how does this change not solve the issue altogether. All users, no matter their machine word size or memory model, are already using 64-bit file offset types. The point being, there's no special treatment as there is with |
These types are defined upstream in terms of their unsuffixed types, and a large part of the surface API in the exposed bindings does the same. The `libc` crate is moving towards providing unsuffixed types and routines that avoid the need for aliases. This intent was expressed on Windows platforms in rust-lang#5032. This patch altogether deprecates all items under Linux musl that are conditionally exposed upstream under the `_LARGEFILE64_SOURCE` feature test macro.
348a55e to
59f8ad5
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Description
This PR removes support for the exposed LFS64 bindings under Linux musl. This follows from the
libccrate's attempts at providing a single, unsuffixed type with which to provide 64-bit functionality.This follows from #5032, where I understood
libcwas meant to provide a single, unsuffixed type and not necessarily support aliases (much less conditional aliases.) Upstream musl also defines the LFS64 types routines in terms of the unsuffixed types and routines.This patch ensures we deprecate these types and the whole
musl/lfs64module in favor of using only the unsuffixed types and routines.Sources
No specific sources are provided. Running the following command with
rgin the main worktree of latest musl should yield search results that show the uniform aliasing mentioned above across all header files.Checklist
libc-test/semverhave been updated*LASTor*MAXare included (see #3131)cd libc-test && cargo test --target mytarget); especially relevant for platforms that may not be checked in CI