-
Notifications
You must be signed in to change notification settings - Fork 1.2k
cleanup: Declare more padding fields as private Padding's #4859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
For anything where the padding field is private, I'm happy to apply this change and get it into a release in the next day or two. Would you mind splitting these out to a separate commit or PR? For everything where the field is public, we can do the change in |
2bcd48f to
a33c485
Compare
For this you can feel free to include anything that is a tier 3 target since occasional breaking changes are fine. freebsd-riscv, openbsd, cygwin, haiku, hurd, csky, mips, riscv32, hexagon, uclibc, and newlib all fall into this category. |
a33c485 to
643c3bd
Compare
b65a896 to
73bf773
Compare
Sure thing, let me play here to see the failures I can't replicate locally in CI first :) |
a0a5285 to
1617435
Compare
Some were already done, more were missing
As previous commit, but tackle the *padding* fields
We have some leftovers of alignment data that is exposed
1617435 to
ba3218b
Compare
|
@rustbot ready |
Description
We have more fields that are padding areas that are currently marked as
public and not marked as Padding, which is causing the generated Hash
and PartialEq implementations to take care of them wrongly.
So fix them
Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI