implement libm::exp and its variants for i586 with inline assembly #1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
reviewed
Dec 6, 2025
libm/src/math/arch/i586.rs
Outdated
Comment on lines
63
to
67
|
|
||
| macro_rules! x87exp { | ||
| ($float_ty:ident, $word_size:literal, $fn_name:ident, $load_op:literal) => { | ||
| pub fn $fn_name(mut x: $float_ty) -> $float_ty { unsafe { | ||
| core::arch::asm!( |
Contributor
There was a problem hiding this comment.
You mentioned async and at #1021 that the results can be platform-dependent. I think this is worth putting in a comment in case anybody runs into it. Hopefully nobody ever will, but a hint would be nice if it shows up.
Otherwise, LGTM.
quaternic
commented
Dec 6, 2025
Contributor
|
That’s more detail than I was expecting, looks great :)
|
tgross35
reviewed
Dec 6, 2025
tgross35
reviewed
Dec 6, 2025
… fix precision issues
Co-authored-by: Juho Kahala <57393910+quaternic@users.noreply.github.com>
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve the severe imprecision (~2%) that is due to inconsistent rounding.
Closes: #1021