Use u32 for the index --contiains #9#10
Open
Ericson2314 wants to merge 2 commits intorust-ethereum:masterfrom
Open
Use u32 for the index --contiains #9#10Ericson2314 wants to merge 2 commits intorust-ethereum:masterfrom
Ericson2314 wants to merge 2 commits intorust-ethereum:masterfrom
Conversation
`Fn` is overkill
Yes, we are indexing memory, but the index itself is manipulated in many non-numerical ways (XORs, etc.). I think it's better to use the fixed size type, just as one would do with a hash algorithm.
This was referenced Jan 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yes, we are indexing memory, but the index itself is manipulated in many non-numerical ways (XORs, etc.). I think it's better to use the fixed size type, just as one would do with a hash algorithm.