Skip to content

Conversation

@thejpster
Copy link
Member

  • Bumps MSRV to 1.87 to avoid failure seen in Support directory deletion #210
  • Removes core-error feature, because MSRV is high enough we can just always turn it on

Fixes heapless 0.9.2 build.
MSRV now high enough that we don't need it
@jannic
Copy link
Contributor

jannic commented Dec 19, 2025

Wouldn't it be more robust to set resolver.incompatible-rust-versions="fallback" (or resolver = "3" or edition = '2024' which changed the default to fallback)?

That way, cargo will automatically select versions of dependencies that are compatible with the current compiler.
Bumping the rustc version used in CI only helps with the new MSRV of heapless, but will break again once any dependency updates to a more recent MSRV.

Copy link
Contributor

@jannic jannic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While setting resolver="3" may still be a good idea, there's nothing wrong with this PR. Approved.

@thejpster thejpster added this pull request to the merge queue Dec 19, 2025
Merged via the queue into develop with commit 7619f4e Dec 19, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants