fix: preserve multipart upload filenames across clients#122
Merged
Conversation
IR: - Add request-body-specific multipart input planning - Keep canonical binary schemas unchanged outside multipart request bodies - Track per-part filename fallbacks from multipart wire names Clients: - Emit UploadFile wrappers only for multipart upload request inputs - Read caller filenames across TypeScript, Go, Python, Java, Kotlin, and Rust clients - Keep text and JSON multipart parts on their existing code paths Tests: - Regenerate multipart-capable goldens across all generators - Pin dynamic filename behavior in cross-client smoke coverage
c808789 to
c23ee7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IR:
multipart/form-dataformat: binaryClients:
{Operation}MultipartRequestBodyTests:
Validation
cargo test --test multipart_runtime_smokejust golden-checkcargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningsgit diff --checkGenerated-client build checks:
npx --yes -p typescript -c 'just golden-build-all'passed TypeScripttsc69/69, TypeScriptvp5/5, and Go 57/57 before Rust registry download failures interrupted the full run.just golden-python::buildpassed Python-httpx 57/57 and Python-requests 57/57.just golden-java::buildpassed Java 58/58.just golden-kotlin::buildpassed Kotlin 58/58.