fix: optional request bodies across generated clients#120
Merged
Conversation
Rust: - Preserve requestBody.required in shared API body planning - Emit Option<&T> for optional request bodies and skip body setup on None - Keep ureq POST-compatible by sending an empty body when optional input is absent Tests: - Regenerate multipart edge-case goldens for reqwest, ureq, and aioduct - Add optional non-multipart request body fixture across all golden suites - Pin JSON, text, binary, and required-body behavior in generated goldens
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes optional request body handling across generated clients, with the Rust generator now preserving
requestBody.requiredthrough API planning and backend emission.What changed
Option<&T>for optional request bodies and keep&Tfor required bodies.None.Validation
cargo test --test golden_tests_rust_reqwest test_optional_request_bodies_golden -- --nocapturecargo test --test golden_tests_rust_ureq test_optional_request_bodies_golden -- --nocapturecargo test --test golden_tests_rust_aioduct test_optional_request_bodies_golden -- --nocapturecargo test --test golden_tests_go_http test_optional_request_bodies_golden -- --nocapturecargo test --test golden_tests_java_okhttp test_optional_request_bodies_golden -- --nocapturecargo test --test golden_tests_kotlin_okhttp test_optional_request_bodies_golden -- --nocapturecargo test --test golden_tests_python_requests test_optional_request_bodies_golden -- --nocapturecargo test --test golden_tests_python_httpx test_optional_request_bodies_golden -- --nocapturecargo test --test golden_tests_typescript_fetch test_optional_request_bodies_golden -- --nocapturecargo test --test multipart_runtime_smoke -- --nocapturecargo fmt --checkgit diff --checkoptional-request-bodiespackages for reqwest, ureq, and aioduct.