fix: align multipart part content types across clients#119
Merged
Conversation
adamcavendish
force-pushed
the
adamcavendish/align-multipart-encoding
branch
from
1f54b4c to
bc16c6e
Compare
IR: - Preserve OpenAPI multipart encoding contentType in request bodies - Share multipart part planning across generator backends - Reject non-JSON complex part encodings consistently Clients: - Emit per-part Content-Type for TypeScript, Go, Python, OkHttp, and Rust - Use controllable TypeScript Blob multipart bodies and backend-native part builders - Keep public SDK method signatures unchanged Tests: - Add explicit multipart encoding fixture across all golden suites - Regenerate multipart goldens with default and explicit part content types - Verify golden checks and generated-client build checks
adamcavendish
force-pushed
the
adamcavendish/align-multipart-encoding
branch
from
bc16c6e to
92617cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align multipart request construction across all supported generators so every backend preserves explicit
encoding.<part>.contentTypeand applies the same default per-partContent-Typerules.What changed
Content-Typeheaders consistently for binary, text/primitive, and JSON object/array parts.FormDatamultipart bodies with explicitBlobmultipart construction so part headers and boundaries are controllable.multipart-explicit-encoding.yamlacross every golden suite, then regenerate affected multipart goldens.Validation
cargo check --libjust golden-checkjust golden-build-allwith a temporarytscPATH shim callingnpx --yes -p typescript tscbecause baretscis not installed locallyBuild coverage from
golden-build-all:tsc: 68/68 passedvp: 5/5 passed