bitreq: Remove punycode dependency #423
Open
+8
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
previously approved these changes
Dec 8, 2025
Open
Member
|
Needs rebase after #424 went in, I figured this one was smaller so better to merge the other first. |
punycode was used to convert non-ASCII hostnames in URLs. This can instead be done by the calling site. Remove the punycode function and dependence.
jamillambert
force-pushed
the
1125-remove-punycode
branch
from
a9219ec to
9da1dda
Compare
Collaborator
Author
|
Rebased. Merge conflict was just two adjacent line changes. Re updated lockfiles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
punycodewas used to convert non-ASCII hostnames in URLs. This can instead be done by the calling site.Remove the
punycodefunction and dependence. Addresses one of the points from #402.Tested with an extended ascii character in the host bücher.de before and after on unix, both parse fine. But non ascii Japanese characters parsed with
punycodeand do not after this change.