fix(specs): align validate_owner harness with processor logic#168
Draft
Stevengre wants to merge 1 commit intocodex/upstream/bootstrap-runtime-verification-max-signers-3from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates the shared
validate_ownerharness to mirrorProcessor::validate_owner: iterate only overmultisig.signers[..multisig.n], track matched positions, and count unique signer matches.Context
The shared harness diverged from the processor logic in two places: it iterated over all signer slots, and it counted matches without the processor's
matched[position]deduplication. That mismatch kept multisig proofs exploring signer-equality branches that the real processor would already have discharged.Red vs Green
Red:
Processor::validate_owner.test_process_revoke_multisigkept its frontier insidevalidate_ownersigner/key equality.Green:
References
program/src/processor.rs::validate_owner