Skip to content

Comments

await: directly check for context.Canceled errors:#21

Open
dfuentes wants to merge 1 commit intomainfrom
df/propogate-wrapped-context-canceled-errors
Open

await: directly check for context.Canceled errors:#21
dfuentes wants to merge 1 commit intomainfrom
df/propogate-wrapped-context-canceled-errors

Conversation

@dfuentes
Copy link
Contributor

@dfuentes dfuentes commented Dec 2, 2025

  • Use a direct equality check to tell if a suboutine was ended due to a context.Canceled error. The old check using errors.Is() would falsely catch library errors that themselves wrap context.Canceled. In those cases, we should propogate the error instead of exiting cleanly.

- Use a direct equality check to tell if a suboutine was ended due to a
context.Canceled error.  The old check using errors.Is() would falsely
catch library errors that themselves wrap context.Canceled.  In those
cases, we should propogate the error instead of exiting cleanly.
@dfuentes dfuentes requested a review from abraithwaite December 2, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants