Adds a JSON marshalling handler for loader types:#17
Merged
Conversation
Contributor
dfuentes
commented
May 5, 2025
dfuentes
commented
- When martialling, omit the "Builder:" layer of json and just marshal the loaded type directly.
- When martialling, omit the "Builder:" layer of json and just marshal the loaded type directly.
dfuentes
force-pushed
the
df/marshal-loader-types
branch
from
44ef3b1 to
6d6070c
Compare
abraithwaite
approved these changes
May 5, 2025
Member
abraithwaite
left a comment
abraithwaite
left a comment
There was a problem hiding this comment.
Let's add a simple sanity check test to this but otherwise LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.