Conversation
runpod-Henrik
left a comment
There was a problem hiding this comment.
Review
Clean, complete change. The constant is used consistently everywhere (build.py:346, app.py:108) so bumping it propagates correctly — no hardcoded 500s left behind.
Question: is 1.5GB the actual platform-enforced limit?
The client-side check (MAX_TARBALL_SIZE_MB) is a pre-flight guard. If the RunPod platform upload endpoint enforces a different limit, users will pass the client check but get an opaque server-side error. Does the backend actually accept up to 1.5GB today, or is this change ahead of a platform change?
Nit: unit inconsistency in updated strings
app.py docstring and build.py docstring say 1500MB, markdown docs say 1.5GB. Both correct but inconsistent — worth picking one style across all four places.
Positives
- All enforcement code references the constant, not a literal — single change propagates everywhere correctly
- Test updated to 1600MB to stay above the new limit — correct
- No stray
500references left in size-related code
Verdict: PASS pending confirmation that the backend supports 1.5GB today.
🤖 Reviewed by Henrik's AI-Powered Bug Finder
we will have to keep an eye on storage costs and sls cold starts on the host side as part of this, but ml workloads often require pretty large dependencies