feat(logging): improve worker log formatting and retry UX

[deanq]

Summary

• Configure uvicorn loggers (uvicorn, uvicorn.error, uvicorn.access) to use the same format as custom worker logs — eliminates the dual-format noise in container output
• Change volume unpack retry attempts to 1-indexed (attempt 1 of 3 → readable) instead of attempt 0 of 3
• Log non-final retry failures as WARNING (no traceback) instead of ERROR — reduces noise; final failure still raises
• Add === 60-char section separators around key startup phases in unpack_volume.py and lb_handler.py to make container logs scannable at a glance

Test plan

• All existing tests pass (240 tests, verified via pre-commit hook)
• test_unpack_volume.py updated to assert new 1-indexed messaging and WARNING log level
• No new dependencies; uv.lock not included in this PR
• Quality checks pass: ruff format, ruff check, mypy, pytest

Files changed

File	Change
src/logger.py	Add uvicorn logger configuration to setup_logging()
src/lb_handler.py	Add section header around mothership app import
src/unpack_volume.py	1-indexed retries, WARNING on non-final failures, section separators
tests/unit/test_unpack_volume.py	Update assertions for new log behavior

[Copilot]

Pull request overview

This pull request improves the logging experience for worker-flash containers by standardizing log formats, improving retry UX, and adding visual section separators. The changes make container logs more scannable and reduce noise from expected retry failures.

Changes:

• Configure uvicorn loggers to use the same format as custom worker logs, eliminating inconsistent formatting
• Improve retry logging by using 1-indexed attempt numbers, logging non-final failures as WARNING instead of ERROR, and adding clear wait messages between retries
• Add 60-character section separators around key startup phases to improve log scannability

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/logger.py	Adds uvicorn logger configuration to unify log formatting across all loggers
src/unpack_volume.py	Updates retry logic to use 1-indexed attempts, logs non-final failures as WARNING, and adds section separators
src/lb_handler.py	Adds section separators around application import phase
tests/unit/test_unpack_volume.py	Updates test assertions to match new logging behavior (WARNING for non-final failures, 1-indexed attempts)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Uvicorn loggers likely have no handlers at the time setup_logging() is called during module import, so this loop won't apply the formatter to any handlers. Uvicorn creates its handlers later when the server starts. Consider either adding handlers if they don't exist, or configuring uvicorn's logging via uvicorn's configuration options when starting the server.

Suggested change

	formatter = logging.Formatter(fmt)
	for logger_name in ["uvicorn", "uvicorn.error", "uvicorn.access"]:
	uvicorn_logger = logging.getLogger(logger_name)
	uvicorn_logger.setLevel(level)
	# Suppress access logs unless DEBUG
	if logger_name == "uvicorn.access" and level != logging.DEBUG:
	uvicorn_logger.setLevel(logging.WARNING)
	# Ensure handlers use our formatter
	formatter = logging.Formter(fmt)
	for logger_name in ["uvicorn", "uvicorn.error", "uvicorn.access"]:
	uvicorn_logger = logging.getLogger(logger_name)
	uvicorn_logger.setLevel(level)
	# Suppress access logs unless DEBUG
	if logger_name == "uvicorn.access" and level != logging.DEBUG:
	uvicorn_logger.setLevel(logging.WARNING)
	# Ensure each uvicorn logger has at least one handler so the formatter is applied
	if not uvicorn_logger.handlers:
	uvicorn_handler = logging.StreamHandler(stream)
	uvicorn_handler.setFormatter(formatter)
	uvicorn_logger.addHandler(uvicorn_handler)
	# Ensure all handlers use our formatter

[Copilot]

The _UNPACKED flag is set to True here, but it was already set to True on line 129 at the start of the critical section. This assignment is redundant and can be removed.

Suggested change

_UNPACKED = True

[deanq]

Closing - breaks RunPod console logs due to uvicorn handler timing issue (race condition at import time). Will reopen with proper fix following runpod-python patterns.