Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| ErrorBar::new_both(x, y, x_err_low, x_err_high, err_low, err_high)? | ||
| } else { | ||
| ErrorBar::new_vertical(x, y, err_low, err_high)? | ||
| } |
There was a problem hiding this comment.
Horizontal ErrorBar orientation lost during deserialization
Medium Severity
The ErrorBar deserialization only checks for "Both" orientation, falling through to ErrorBar::new_vertical for all other values including "Horizontal". Since serialization uses format!("{:?}", error.orientation) which produces "Vertical", "Horizontal", or "Both", any Horizontal error bar silently becomes Vertical after a roundtrip through FigureScene.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches core rendering, scene serialization/deserialization, and adds multiple new GPU compute paths; regressions could affect plot fidelity, camera/view state, and backwards compatibility of saved scenes.
Overview
Adds broader figure/axes state to the scene schema (per-axes metadata, active axes, z limits, text/legend styles, and 3D view angles) and re-applies stored 3D view angles on render via a new
Camera::set_view_angles_deg.Expands supported plot kinds with
Line3,Quiver,Pie, richerArea(optional lower curve), and a majorErrorBaroverhaul (x/y directions, orientation, line style, cap sizing, and optional markers), plus overlay/export rendering for z-labels and pie slice labels.Introduces new GPU vertex packers + WGSL shaders for
area,errorbar,image(truecolor),line3,quiver, andstem, and updates plot implementations to optionally render from GPU buffers; TS bindings are updated to includeline3.Written by Cursor Bugbot for commit 58c3292. This will update automatically on new commits. Configure here.