fix(ci): improve review-enforcement reliability#576
Open
john-weiler wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## chore/review-enforcement-workflow #576 +/- ##
=====================================================================
- Coverage 82.76% 82.67% -0.10%
=====================================================================
Files 119 119
Lines 9750 9725 -25
=====================================================================
- Hits 8070 8040 -30
- Misses 1680 1685 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShuaiShao93
approved these changes
May 4, 2026
![baz-reviewer[bot]](https://avatars.githubusercontent.com/in/933528?s=60&v=4){kind=small}
Contributor
|
No activity for 30 days — this PR will be closed in 5 days unless updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Three fixes to the shared
review-enforcement.ymlworkflow:enforce-reviewconcurrency: Cancels in-progress synchronize check runs when an approval event fires, preventing a race condition where the synchronize job completes last and overwrites a passing approval status.Retry logic fix: Previously the retry broke out as soon as
reviews.length > 0, even if all existing reviews were dismissed. Now it retries until a valid non-baz human approval appears, covering eventual consistency after a dismiss→re-approve sequence.Dependabot auto-merge
unstable statusfix: GitHub rejectsenablePullRequestAutoMergefor PRs with cancelled check runs (mergeable_state=unstable). The error was unhandled and crashed the job. Now falls back to a direct merge whenmergeable===true.🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.6 (1M context) noreply@anthropic.com
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Align the review enforcement workflow to cancel concurrent runs and retry listing reviews until a valid non-baz approval appears so synchronize jobs no longer race with approvals. Handle dependabot auto-merge failures by catching unstable status rejections and directly merging when the PR remains mergeable.
enablePullRequestAutoMergeis rejected butmergeable === true.Modified files (1)
Latest Contributors(1)
Modified files (1)
Latest Contributors(1)