fix: firewall rule configured on windows runner reboot#1078
Open
ayush-panta wants to merge 1 commit intomainfrom
Open
fix: firewall rule configured on windows runner reboot#1078ayush-panta wants to merge 1 commit intomainfrom
ayush-panta wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: ayush-panta <ayushkp@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes: Change user data script for Windows runners to wait for interface to become available rather than just sleep for 30 seconds before trying to apply firewall script. The goal is to make firewall rule exist on instance reboot and remove need for manual intervention for host-to-IP mapping test errors.
Testing done: I tested on my own Windows instance with a more minimal test script (higher maxWait but that is irrelevant):
After reboot, with SSM in instance we observe the following, showing that the firewall rule persisted:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.