Skip to content

update item-link#9951

Closed
NorbsCode wants to merge 1 commit intorunelite:masterfrom
NorbsCode:item-link
Closed

update item-link#9951
NorbsCode wants to merge 1 commit intorunelite:masterfrom
NorbsCode:item-link

Conversation

@NorbsCode
Copy link
Copy Markdown
Contributor

@NorbsCode NorbsCode commented Dec 23, 2025

Changes

Enhanced Tooltips

  • Added item icons to tooltips
  • Added examine text/description for items
  • Added skill icons for attack, defence, and other stat bonuses
  • Added spell icons for High/Low Alch values
  • Added Attack Speed display for weapons
  • Added Members (P2P) indicator
  • Added (Untradeable) indicator for non-tradeable items
  • Multiple items on same line now show side-by-side tooltips
  • Improved tooltip positioning (no longer goes off-screen on edges)
  • Slightly brighter background for better readability

Smart Abbreviations

  • Added 500+ common OSRS abbreviations (tbow, bcp, tassets, ags, dwh, scythe, sang, rapier, fang, shadow, bowfa, etc.)
  • Abbreviations automatically expand to full item names
  • GP amounts (1m, 500k, 2.5b) are now detected and colored by value

Display Improvements

  • Removed brackets from item links (cleaner look)
  • Items now display as colored text naturally in chat

Filtering Options

  • Added configurable item name filter
  • Added minimum/maximum value filters
showcase.1.mp4

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Dec 23, 2025

@NorbsCode
Copy link
Copy Markdown
Contributor Author

NorbsCode commented Dec 23, 2025

Fixing build fail errors now

@runelite-github-app
Copy link
Copy Markdown

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@riktenx
Copy link
Copy Markdown
Member

riktenx commented Dec 30, 2025

  • Don't use HttpURLConnection for network requests. @Inject Runelite's OkHttpClient and use that. But also see next comment.
  • I don't really understand why you need the wiki API call in the first place when you've apparently got this item database json? maybe there's something I'm missing here
  • what

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 30, 2025
@riktenx
Copy link
Copy Markdown
Member

riktenx commented Jan 25, 2026

closing because the above hasn't been addressed, if you fix it you can make a new PR

@riktenx riktenx closed this Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin change size-l waiting for author waiting for the pr author to make changes or respond to questions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants