Skip to content

Create loot-lister#9905

Merged
riktenx merged 4 commits intorunelite:masterfrom
DoinkOink:loot-lister
Dec 27, 2025
Merged

Create loot-lister#9905
riktenx merged 4 commits intorunelite:masterfrom
DoinkOink:loot-lister

Conversation

@DoinkOink
Copy link
Copy Markdown
Contributor

Displays a list of recently received loot on screen with a configurable price threshold.

plugin_example

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Dec 20, 2025

@ChunkyAtlas
Copy link
Copy Markdown
Contributor

ChunkyAtlas commented Dec 20, 2025

Build failed
net.runelite.pluginhub.packager.PluginBuildException: loot-lister: "displayName" must be set
at net.runelite.pluginhub.packager.PluginBuildException.of(PluginBuildException.java:54)
at net.runelite.pluginhub.packager.Plugin.assembleDisplayData(Plugin.java:795)
at net.runelite.pluginhub.packager.Plugin.build(Plugin.java:550)
at net.runelite.pluginhub.packager.Packager.buildPlugin(Packager.java:215)
at net.runelite.pluginhub.packager.Packager.lambda$buildPlugins$0(Packager.java:155)
at java.base/java.lang.Thread.run(Thread.java:829)

loot-lister: "displayName" must be set
in file /tmp/pluginhub-package17194856421371603283/loot-lister/repo/runelite-plugin.properties

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Dec 20, 2025

Internal use only: Reviewer details Maintainer details

@riktenx
Copy link
Copy Markdown
Member

riktenx commented Dec 26, 2025

You need to remove your overlay on shutDown

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 26, 2025
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 27, 2025
@riktenx
Copy link
Copy Markdown
Member

riktenx commented Dec 27, 2025

This is not blocking feedback but your overlay code is just weird and was sort of a pain to review. Typically your overlay should just be stateless and then your plugin's logic can handle all of the caching (and staling of old entries) for recent drops in onLootReceived. I think if you pursue refactoring to that way you'll find that the code gets a lot easier to manage.

@riktenx riktenx merged commit f980cfd into runelite:master Dec 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants