Skip to content

fix(identities): keep cancel edits out of preview#1848

Open
haocyan0723-code wants to merge 1 commit into
runbox:masterfrom
haocyan0723-code:fix-identities-cancel-preview-update
Open

fix(identities): keep cancel edits out of preview#1848
haocyan0723-code wants to merge 1 commit into
runbox:masterfrom
haocyan0723-code:fix-identities-cancel-preview-update

Conversation

@haocyan0723-code
Copy link
Copy Markdown

Summary

  • pass a copy of the selected identity into the edit dialog
  • keep unsaved edits from changing the identity card behind the dialog

Verification

  • git diff --check
  • verified with a copy/mutation check that changing dialog data leaves the original identity unchanged

Closes #1571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#Identities: When editing identities, the Cancel button doesn't appear to do anything

1 participant