Skip to content

fix(index): clarify total messages in sync prompt #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haocyan0723-code wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(index): clarify total messages in sync prompt #1847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/app/xapian/searchservice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,15 +726,16 @@ export class SearchService {
0)
/ (1024 * 1024)
);
const totalMessages = partitions.reduce((prev, curr, partitionNdx) => prev +
curr.numberOfMessages,
const remainingMessages = partitions.reduce((prev, curr, partitionNdx) => prev +
(partitionNdx < 1 ? 0 : curr.numberOfMessages),
0);
const totalMessages = doccount + remainingMessages;

dialog.componentInstance.title = 'Continue synchronizing?';
dialog.componentInstance.question = `Already synchronized index for
${doccount} of
your most recent messages. To synchronize entire index
(for ${totalMessages} messages),
your most recent messages. To synchronize the entire index
(${totalMessages} messages total),
there's an additional download of ${remainingDownloadMB} MB.`;
dialog.afterClosed()
.subscribe(res => {
Expand Down