Fix #1537: warn when app passwords are disabled#1807
Open
Keegil wants to merge 2 commits into
Open
Conversation
Show an explicit warning in the app password creation section when the main app password switch is off, and cover the behavior with a component spec. runbox#1537
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Users could create a new app password while the overall app-password feature was disabled. The page already had the main toggle, but it was easy to miss, which could leave users with a newly created password that would not work.
Solution
This change surfaces a clear warning directly in the New App Password section whenever
is_app_pass_enabledis false. That places the warning at the point where the user is about to create a password, which matches the issue report without changing the underlying toggle behavior.Testing
./node_modules/.bin/eslint src/app/account-security/app-passwords.component.ts src/app/account-security/app-passwords.component.html src/app/account-security/app-passwords.component.spec.ts./node_modules/.bin/tsc -p tsconfig.json --noEmitnpm run build./node_modules/.bin/ng test --watch=false --browsers=FirefoxHeadless --include src/app/account-security/app-passwords.component.spec.tsbut the environment does not have a Firefox binary installed for Karma (No binary for FirefoxHeadless browser on your platform)Closes #1537