Skip to content

Fix #1537: warn when app passwords are disabled#1807

Open
Keegil wants to merge 2 commits into
runbox:masterfrom
Keegil:fix/issue-1537
Open

Fix #1537: warn when app passwords are disabled#1807
Keegil wants to merge 2 commits into
runbox:masterfrom
Keegil:fix/issue-1537

Conversation

@Keegil
Copy link
Copy Markdown
Contributor

@Keegil Keegil commented Mar 27, 2026

Summary

  • add an explicit warning in the New App Password section when the master app-password switch is disabled
  • keep the existing enable/disable flow unchanged while making the disabled state much easier to notice before creating a password
  • add a focused component spec that covers the warning visibility for enabled and disabled states
  • update the generated changelog

Problem

Users could create a new app password while the overall app-password feature was disabled. The page already had the main toggle, but it was easy to miss, which could leave users with a newly created password that would not work.

Solution

This change surfaces a clear warning directly in the New App Password section whenever is_app_pass_enabled is false. That places the warning at the point where the user is about to create a password, which matches the issue report without changing the underlying toggle behavior.

Testing

  • ./node_modules/.bin/eslint src/app/account-security/app-passwords.component.ts src/app/account-security/app-passwords.component.html src/app/account-security/app-passwords.component.spec.ts
  • ./node_modules/.bin/tsc -p tsconfig.json --noEmit
  • npm run build
  • attempted ./node_modules/.bin/ng test --watch=false --browsers=FirefoxHeadless --include src/app/account-security/app-passwords.component.spec.ts but the environment does not have a Firefox binary installed for Karma (No binary for FirefoxHeadless browser on your platform)

Closes #1537

Keegil added 2 commits March 27, 2026 18:34
Show an explicit warning in the app password creation section when the main app password switch is off, and cover the behavior with a component spec.

runbox#1537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#Security Make app password screen warn user when creating a new app password but the overall feature switch is off.

1 participant