Conversation
0f73eb6 to
1844f5e
Compare
|
@postmodern looks like a combination of #236 #237 #242 gets things going again. Lets get those merged first and I'll rebase and squash. |
|
Other three PRs have been merged. Shall I "squash and merge` or do you want to rebase+squash? |
| homepage: https://github.com/rubysec/bundler-audit#readme | ||
|
|
||
| required_ruby_version: ">= 1.9.3" | ||
| required_ruby_version: ">= 2.4.0" |
There was a problem hiding this comment.
@joshRpowell Just curious why we're dropping support for Ruby 2.3? Even Thor 1.x supports Ruby >= 2.0.0.
There was a problem hiding this comment.
@postmodern following the lead in popular OSS elsewhere now that 2.3 is EOL: https://github.com/search?q=drop+ruby+2.3&type=Commits
if we decide to keep, we'll have to look through locking in dependency versions per ruby version: https://travis-ci.org/rubysec/bundler-audit/jobs/640082516?utm_medium=notification&utm_source=github_status
look forward to your thoughts. will polish off whats need.
There was a problem hiding this comment.
Since the whole purpose of the bundles is to have Gemfile.locks to test the Scanner class against, we should probably just commit the Gemfile.lock files to lock down our testing dependencies. This would prevent newer versions of gems from leaking. I have some old Gemfile.lock files locally that I could commit?
There was a problem hiding this comment.
Committed the Gemfile.lock files and Travis is all green. I'll probably bump the required ruby version up to 2.0.0, due to the differences between 1.9 and 2.0.
There was a problem hiding this comment.
given this comment when 2.1 & 2.2 were dropped. Should 2.3 be the required ruby version?
There was a problem hiding this comment.
I'm kind of opposed to using required_ruby_version as "supported ruby version". To me, "required version" means the absolute minimum version that the code needs to run. We should set required_ruby_version based on what Ruby features we're using, or if we hit some show-stopping bug in a particular Ruby version and we must blacklist the version(s) in order to prevent users from hitting the bug and constantly re-reporting the issue to use. Not to mention it would be a lot of work if every gem maintainer had to bump required_ruby_version each time another Ruby version reached EoL.
d9e23c0 to
a5daf6a
Compare
Healthy discussion. 👍 Will close this and let you take you take it from here. |
https://www.ruby-lang.org/en/news/2019/12/25/ruby-2-7-0-released/