Reject multiple transfer-encoding headers and transfer-encoding headers with obs#205
Open
jeremyevans wants to merge 1 commit intoruby:masterfrom
Open
Reject multiple transfer-encoding headers and transfer-encoding headers with obs#205jeremyevans wants to merge 1 commit intoruby:masterfrom
jeremyevans wants to merge 1 commit intoruby:masterfrom
Conversation
Member
|
@jeremyevans /cc @ioquatix I recently revised our repository permissions, which previously allowed all committers to write. In the process, I forgot to explicitly keep the write access for you. I have restored it now. Sorry to your inconvenience. |
|
Thank you for the fix! I reviewed the changes and the two Transfer-Encoding smuggling vectors are correctly addressed:
Both test cases (test_multiple_transfer_encoding_headers and test_transfer_encoding_header_with_obs) cover the attack scenarios appropriately. The fix is RFC 9112 6.1 and 5.2 compliant. Thanks @hsbt and @jeremyevans ! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #204