Add some specs for bitwise operators in Process::Status #1217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're pretty minimal, since the method is deprecated and will be removed in Ruby 3.5. (Ruby 3.3 warns for removal in 3.4, but 3.4-dev still has the method and warns for removal in 3.5)
They're pretty minimal, since the method is deprecated and will be removed in Ruby 3.5. (Ruby 3.3 warns for removal in 3.4, but 3.4-dev still has the method and warns for removal in 3.5)
Member
Author
|
This fixes an issue of #1216 ("Process::Status#& and Process::Status#>> are deprecated") |
andrykonchin
approved these changes
Nov 27, 2024
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically
Process:Status#&andProcess::Status#>>. These methods have been deprecated in Ruby 3.3, and are planned to be removed (the warning of Ruby 3.3 says removed in 3.4, but today's version of Ruby 3.4-dev still has them and says it will be removed in 3.5).I kept the specs pretty basic, so there's no spec to test if we call
to_inton the argument, or what happens if the argument is not an integer, since these methods are deprecated I would say we can do without it.