Skip to content

Fix compatibility to ruby-3.2 #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eregon merged 2 commits into from
Jan 18, 2026
+17 −3
Merged

Fix compatibility to ruby-3.2 #861

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf7190d
Fix compatibility to ruby-3.2
larskanis Jan 18, 2026
df8bdad
Add new RubyInstaller releases 4.0.1-1 and 3.2.10-1
larskanis Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion generate-windows-versions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
# Validate all the URLs in the versions json
def validate(versions, allowed_urls_regexps)
versions.values.flat_map(&:values).each do |url|
if allowed_urls_regexps.none? { |regexp| regexp.match? url }
if allowed_urls_regexps.none? { |regexp| regexp.match? url.to_s }
Copy link
Copy Markdown
Member

@eregon eregon Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we should convert the URI to a String earlier, we don't want to have URI objects in the JSON.
It works currently but might as well have consistent types for this method.
I'll fix it.

Copy link
Copy Markdown
Member

@eregon eregon Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#862

raise SecurityError, "Unexpected URL: #{url}"
end
end
Expand Down
Loading