Suppress spurious warning for non-gem stdlib libraries#2929
Merged
Conversation
When running `rbs collection install` with an existing lockfile that includes non-gem standard libraries (like socket, pathname), the lockfile generator would emit a misleading warning: Cannot find `socket` gem. Using incorrect Bundler context? This happens because these libraries are part of Ruby's standard library but are not distributed as gems, so they never appear in Bundler's gem specifications. With an existing lockfile, the code path bypasses stdlib detection and falls through to the gem_hash lookup, which fails and triggers the warning. Add NONGEM_STDLIBS constant listing all non-gem standard libraries that have type definitions in stdlib/, and skip the warning for them. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NONGEM_STDLIBSconstant listing standard libraries that are not distributed as gems (e.g.,socket,pathname,monitor) but have type definitions instdlib/<name>gem" warning for these libraries duringrbs collection installProblem
When
rbs_collection.yamlincludes non-gem standard libraries likesocket, runningrbs collection installa second time (with an existing lockfile) emits a misleading warning:This happens because with an existing lockfile,
assign_gemtakes theexisting_lockfilecode path, bypassing stdlib detection viafind_source. It then checksgem_hash(Bundler's specs) which naturally doesn't include non-gem libraries, triggering the warning.🤖 Generated with Claude Code