Conversation
Simplify rbs_loc_range struct from 4 fields (start_char, end_char, start_byte, end_byte) back to 2 fields (start, end), now representing byte positions instead of character positions. Update ast_translation template to pass start_byte/end_byte from rbs_location_range, and remove rbs_new_location3 in favor of rbs_new_location2 which now accepts byte positions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Buffer: - Change ranges to use bytesize instead of char size - Use byteslice for lines and sub_buffer - Switch Prism integration from start_character_offset to start_offset Location: - Add start_byte/end_byte as primary byte position methods - Add start_char/end_char for character positions (computed from bytes) - Add start_byte_column/end_byte_column and start_char_column/end_char_column - Deprecate start_pos/end_pos in favor of start_char/start_byte - Deprecate start_column/end_column in favor of start_byte_column/start_char_column - Use byteslice for source extraction Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Rewriter: use start_byte/end_byte, start_byte_column, bytesplice - Errors: use start_byte_column/end_byte_column for marker alignment - Writer: use start_byte_column for indentation - Locator: add byte_column/char_column keyword arguments to find/find2, deprecate column keyword, add char_column_to_byte_column helper - CommentBlock, LocationHelper: use Prism start_offset (byte) instead of start_character_offset (char) - ParserAux, Declarations: use start_byte/end_byte - Update test expectation for byte-based column values Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.