Skip to content

Conversation

@nobu
Copy link
Member

@nobu nobu commented Dec 3, 2024

At least Visual Studio 2015 (MSVC 14.0) provides the macro conforming to C99.
And, float.h is necessary to use _finite() like the current code.

At least Visual Studio 2015 (MSVC 14.0) provides the macro conforming
to C99.
@nobu
Copy link
Member Author

nobu commented Dec 4, 2024

I see, the problem is mingw, not mswin.

https://github.com/ruby/prism/actions/runs/12141353366/job/33853261523?pr=3274#step:4:37

src/prism.c:4145:34: error: conversion from 'double' to 'float' may change value [-Werror=float-conversion]
 4145 |     if (errno == ERANGE && isinf(value)) {
      |                                  ^~~~~

@kddnewton
Copy link
Collaborator

Yeah, I couldn't get the build to pass using isinf directly. I think mingw is non-conforming.

@kddnewton
Copy link
Collaborator

Unless there's a way around it, I think we need to keep it as-is.

@kddnewton
Copy link
Collaborator

Superseded by #3307

@kddnewton kddnewton closed this Dec 12, 2024
@nobu nobu deleted the isinf branch January 29, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants