parser.c: optimize json_string_unescape#894
Closed
samyron wants to merge 1 commit intoruby:masterfrom
Closed
Conversation
864ef5b to
9535e8a
Compare
9535e8a to
b42e968
Compare
Member
|
Sorry for the delay, I just started a new work and was busy. This PR is interesting, but while reviewing it, it gave me another idea: #902 We already find the With a handcrafted benchmark: benchmark_parsing "some_unescape", JSON.dump([((" "*100) + "\n")*15])
benchmark_parsing "more_unescape", JSON.dump([((" "*100) + "\n")*30])My PR perform significantly better: ( So I think I'll go with #902 |
Contributor
Author
|
No problem on the delay. I appreciate your consideration of this PR. Thank you for coming up with something even better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes
json_string_unescape.Two commits:
\. While scanning, copy the current chunk to the output.If this PR is accepted, I will follow up with an SSE2 implementation.
Benchmarks
Run on a Macbook Air M1.
twitterescaped.json is from simdjson-data.
I should note that the fast path for unescaping a single character accounts for about 1% of the speed increase in
activitypub.json. It's pretty minor.