Skip to content

Fix $VERBOSE restore #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
byroot merged 1 commit into from
Nov 11, 2024
Merged

Fix $VERBOSE restore #704

byroot merged 1 commit into from
Nov 11, 2024

Conversation

@tompng
Copy link
Member

@tompng tompng commented Nov 11, 2024

Found this in ruby ci random failure

  1) Failure:
TestIRB::ShowDocTest#test_show_doc_without_rdoc [/tmp/ruby/src/trunk-random1/test/irb/test_command.rb:775]:
Expected "" to include "Can't display document because `rdoc` is not installed.\n".

The expected warning is suppressed because $VERBOSE is changed to nil

@byroot byroot merged commit 3a09ad1 into ruby:master Nov 11, 2024
@tompng tompng deleted the test_verbose_fix branch November 11, 2024 11:39
tompng added a commit to tompng/ruby that referenced this pull request Nov 11, 2024
@tompng
Fix restoring $VERBOSE in json/json_common_interface_test.rb
7df86fa 
Sync ruby/json#704
@tompng tompng mentioned this pull request Nov 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tompng @byroot