-
Notifications
You must be signed in to change notification settings - Fork 28
Add verify_components.yml workflow #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| name: Verify components | ||
|
|
||
| push: | ||
| branches: "main" | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
|
|
||
| - name: Build | ||
| run: rails g ruby_ui:component:all | ||
|
|
||
| - uses: CatChen/check-git-status-action@v1 | ||
| with: | ||
| fail-if-not-clean: true | ||
| push-if-not-clean: false | ||
| request-changes-if-not-clean: false | ||
| targets: 'app' #optional | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. rails g ruby_ui:component:all can cause changes in Gemfile/Gemfile.lock or js dependencies lock. Do we want to fail the job only if there are changes on component files?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @stephannv , I don't see a reason to be so strict about Gemfile.lock or js dependencies lock. |
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if a PR with the changes was opened so we can review and merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it will. Let's do that later on!