Skip to content

split theme components from slot to components #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sethhorsley merged 1 commit into from
Apr 10, 2025
+47 −42
Merged

split theme components from slot to components #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/components/ruby_ui/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,11 @@ def initialize(**user_attrs)
def default_attrs
{}
end

if Rails.env.development?
def before_template
comment { "Before #{self.class.name}" }
end
end
end
end
16 changes: 16 additions & 0 deletions app/components/ruby_ui/theme_toggle/set_dark_mode.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# frozen_string_literal: true

module RubyUI
class SetDarkMode < ThemeToggle
def view_template(&)
div(**attrs, &)
end

def default_attrs
{
class: "hidden dark:inline-block",
data: {controller: "ruby-ui--theme-toggle", action: "click->ruby-ui--theme-toggle#setLightTheme"}
}
end
end
end
16 changes: 16 additions & 0 deletions app/components/ruby_ui/theme_toggle/set_light_mode.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# frozen_string_literal: true

module RubyUI
class SetLightMode < ThemeToggle
def view_template(&)
div(**attrs, &)
end

def default_attrs
{
class: "dark:hidden",
data: {controller: "ruby-ui--theme-toggle", action: "click->ruby-ui--theme-toggle#setDarkTheme"}
}
end
end
end
32 changes: 0 additions & 32 deletions app/components/ruby_ui/theme_toggle/theme_toggle.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,37 +5,5 @@ class ThemeToggle < Base
def view_template(&)
div(**attrs, &)
end

def light_mode(**user_attrs, &)
light_attrs = mix(default_light_attrs, user_attrs)
div(**light_attrs, &)
end

def dark_mode(**user_attrs, &)
dark_attrs = mix(default_dark_attrs, user_attrs)
div(**dark_attrs, &)
end

private

def default_attrs
{
data: {controller: "ruby-ui--theme-toggle"}
}
end

def default_light_attrs
{
class: "dark:hidden",
data: {action: "click->ruby-ui--theme-toggle#setDarkTheme"}
}
end

def default_dark_attrs
{
class: "hidden dark:inline-block",
data: {action: "click->ruby-ui--theme-toggle#setLightTheme"}
}
end
end
end
7 changes: 3 additions & 4 deletions app/components/shared/navbar.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ def view_template
end

def dark_mode_toggle
RubyUI.ThemeToggle do |toggle|
toggle.light_mode do
ThemeToggle do
SetLightMode do
Button(variant: :ghost, icon: true) do
svg(
xmlns: "http://www.w3.org/2000/svg",
Expand All @@ -42,8 +42,7 @@ def dark_mode_toggle
end
end
end

toggle.dark_mode do
SetDarkMode do
Button(variant: :ghost, icon: true) do
svg(
xmlns: "http://www.w3.org/2000/svg",
Expand Down
4 changes: 2 additions & 2 deletions app/views/docs/getting_started/dark_mode.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def view_template
render Docs::VisualCodeExample.new(title: "Toggle component", context: self) do
<<~RUBY
ThemeToggle do |toggle|
toggle.light_mode do
SetLightMode do
Button(variant: :outline, icon: true) do
svg(
xmlns: "http://www.w3.org/2000/svg",
Expand All @@ -65,7 +65,7 @@ def view_template
end
end

toggle.dark_mode do
SetDarkMode do
Button(variant: :outline, icon: true) do
svg(
xmlns: "http://www.w3.org/2000/svg",
Expand Down
8 changes: 4 additions & 4 deletions app/views/docs/theme_toggle.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ def view_template
render Docs::VisualCodeExample.new(title: "With icon", context: self) do
<<~RUBY
ThemeToggle do |toggle|
toggle.light_mode do
SetLightMode do
Button(variant: :ghost, icon: true) do
svg(
xmlns: "http://www.w3.org/2000/svg",
Expand All @@ -28,7 +28,7 @@ def view_template
end
end

toggle.dark_mode do
SetDarkMode do
Button(variant: :ghost, icon: true) do
svg(
xmlns: "http://www.w3.org/2000/svg",
Expand All @@ -52,11 +52,11 @@ def view_template
render Docs::VisualCodeExample.new(title: "With text", context: self) do
<<~RUBY
ThemeToggle do |toggle|
toggle.light_mode do
SetLightMode do
Button(variant: :primary) { "Light" }
end

toggle.dark_mode do
SetDarkMode do
Button(variant: :primary) { "Dark" }
end
end
Expand Down
Loading