add toggle to combobox trigger #321
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the combobox component to improve accessibility and user interaction by ensuring the popover's open/close state is consistently tracked and toggled. The main changes involve synchronizing the
aria-expandedattribute with the popover state and refactoring the trigger action to toggle the popover instead of just opening it.Accessibility and popover state management:
handlePopoverTogglemethod incombobox_controller.jsto keep thearia-expandedattribute of the trigger element in sync with the popover's actual state.combobox_popover.rbto triggerhandlePopoverTogglewhen the popover is toggled.Refactoring trigger and popover logic:
combobox_trigger.rbfromopenPopovertotogglePopover, allowing users to both open and close the popover via the trigger.combobox_controller.jsby introducing a newtogglePopovermethod, which checks the current state and calls eitheropenPopoverorclosePopoveras appropriate.