Skip to content

Conversation

@pierry01
Copy link
Contributor

@pierry01 pierry01 commented Jul 3, 2025

it seems the way below is more natural and the Combobox#term will be optional
image

at multiple combobox, when you select 2+ elements, the system changes the label for 2 items instead of item_1, item_2, ...

controller: "ruby-ui--combobox",
ruby_ui__combobox_term_value: @term.to_s
ruby_ui__combobox_term_value: @term,
action: "turbo:morph@window->ruby-ui--combobox#updateTriggerContent"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephannv sync with Linkana project
necessary to update the value of the trigger content

@pierry01 pierry01 marked this pull request as ready for review July 3, 2025 14:46
@pierry01 pierry01 requested review from cirdes and stephannv as code owners July 3, 2025 14:46
Copy link
Collaborator

@cirdes cirdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@cirdes cirdes merged commit ec4c623 into ruby-ui:main Jul 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants