Skip to content

Conversation

@sethhorsley
Copy link
Member

@sethhorsley sethhorsley commented Apr 10, 2025

This splits up the theme components from having slots for the light_theme and dark_theme to using SetDarkMode and SetLightMode

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

test/ruby_ui/theme_toggle_test.rb:9

  • [nitpick] Consider using Ruby's constant resolution operator ('::') (i.e., 'RubyUI::SetLightMode') instead of the dot notation to follow conventional Ruby syntax, unless the DSL explicitly requires dot notation.
RubyUI.SetLightMode do

lib/ruby_ui/theme_toggle/set_light_mode.rb:4

  • [nitpick] The view_template method is duplicated from the parent ThemeToggle class. If no customization is needed, consider removing the override to use the inherited implementation and reduce code repetition.
class SetLightMode < ThemeToggle

@sethhorsley sethhorsley merged commit 8f00918 into main Apr 10, 2025
2 checks passed
@sethhorsley sethhorsley deleted the fix-theme-component branch April 10, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants