Skip to content

Restrict separator as type #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephannv merged 2 commits into from
Mar 26, 2025
Merged

Restrict separator as type #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbd4b22
Restrict separator `as` type
stephannv Mar 26, 2025
1d21af8
Update separator_test.rb
stephannv Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ruby_ui/separator/separator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ class Separator < Base
def initialize(as: :div, orientation: :horizontal, decorative: true, **attrs)
raise ArgumentError, "Invalid orientation: #{orientation}" unless ORIENTATIONS.include?(orientation.to_sym)

@as = as.to_sym
@as = as
@orientation = orientation.to_sym
@decorative = decorative
super(**attrs)
Expand Down
2 changes: 1 addition & 1 deletion test/ruby_ui/separator_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def test_render_with_decorative_false

def test_render_with_custom_tag
output = phlex do
RubyUI.Separator(as: "hr")
RubyUI.Separator(as: :hr)
end

assert_match(/<hr/, output)
Expand Down