Switch component implemented #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephannv
approved these changes
Nov 22, 2024
Contributor
stephannv
left a comment
stephannv
left a comment
There was a problem hiding this comment.
Great work. Very nice that you didn't need to use javascript for this component 🥳.
lib/ruby_ui/switch/switch.rb
Outdated
| module RubyUI | ||
| class Switch < Base | ||
| def view_template | ||
| attrs => { include_hidden:, **input_attrs } |
Contributor
There was a problem hiding this comment.
I think we can move this to initializer and allow to pass the checked and unchecked values, what do you think?
def initialize(include_hidden: true, checked_value: "1", unchecked_value: "0", **attrs)
@include_hidden = include_hidden
@checked_value = checked_value
@unchecked_value = unchecked_value
super(**attrs)
end
lib/ruby_ui/switch/switch.rb
Outdated
Comment on lines
21
to
27
| def default_attrs | ||
| { | ||
| class: "hidden peer", | ||
| type: "checkbox", | ||
| include_hidden: true, | ||
| value: "1" | ||
| } |
Contributor
There was a problem hiding this comment.
I think we should not allow the user to change the type and classes of the hidden checkbox, because this could break the component behavior, so this method wouldn't be necessary and we could write something like:
input(**attrs.merge(type: "checkbox", class: "hidden peer", value: @checked_value))
stephannv
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Switch component base in the ShadCn styles but using the pseudo-classes to style the componente based in the checked state of the hidden input.
One design decision that is up to debate is the inclusion of the flag include_hidden inspired by the Rail's checkbox implementation to avoid sending no value on form submission when the switch is off.
Here are the examples to ruby-ui/web:
