Skip to content

fix ruby_ui-js refs #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sethhorsley merged 2 commits into from
Nov 10, 2024
Merged

fix ruby_ui-js refs #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a4eb0f
Update index.js.tt
mhamza15 Nov 9, 2024
28e5522
Update install_generator.rb
mhamza15 Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/generators/ruby_ui/install/install_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,10 @@ def install_stuff

def pin_ruby_ui_js
stimulus_path = Rails.root.join("app/javascript/application.js")
package_name = "ruby_ui-js"
package_name = "ruby_ui_js"

say "Add RubyUI Stimulus controllers"
# run "mkdir -p app/javascript/controllers/ruby_ui-js"
# run "mkdir -p app/javascript/controllers/ruby_ui_js"
template "index.js", "app/components/ruby_ui/index.js"

if using_importmap?
Expand All @@ -122,7 +122,7 @@ def pin_ruby_ui_js

fix_import_maps!
else
say "Add ruby_ui-js package"
say "Add ruby_ui_js package"
run "yarn add #{package_name}"

append_to_file stimulus_path, "\nimport \"../components/ruby_ui\";\n"
Expand Down
2 changes: 1 addition & 1 deletion lib/generators/ruby_ui/install/templates/index.js.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ import { application } from "../../../app/javascript/controllers/application";
// Register all controllers
// application.register("ruby-ui--combobox", ComboboxController);

import RubyUI from "ruby_ui-js";
import RubyUI from "ruby_ui_js";
RubyUI.initialize(application);