FIX CHECKBOX_GROUP #182
Merged
FIX CHECKBOX_GROUP #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierry01
commented
Nov 5, 2024
| this.#handleRequired(); | ||
| } | ||
|
|
||
| #handleRequired() { |
Contributor
Author
There was a problem hiding this comment.
it's necessary to run the same code in connect and onChange
pierry01
commented
Nov 5, 2024
| rbui__form_field_target: "input", | ||
| rbui__checkbox_group_target: "checkbox", | ||
| action: "input->rbui--form-field#onInput invalid->rbui--form-field#onInvalid change->rbui--checkbox-group#onChange" | ||
| action: "change->rbui--checkbox-group#onChange change->rbui--form-field#onInput invalid->rbui--form-field#onInvalid" |
Contributor
Author
There was a problem hiding this comment.
the correct use of actions here is change, not input
change->rbui--checkbox-group#onChange needs to run before the validation of change->rbui--form-field#onInput and invalid->rbui--form-field#onInvalid
pierry01
commented
Nov 5, 2024
| data: { | ||
| rbui__form_field_target: "input", | ||
| action: "input->rbui--form-field#onInput invalid->rbui--form-field#onInvalid" | ||
| action: "change->rbui--form-field#onInput invalid->rbui--form-field#onInvalid" |
Contributor
Author
There was a problem hiding this comment.
same situation... change instead of input for radio
pierry01
commented
Nov 5, 2024
| #getValidationMessage() { | ||
| const input = this.inputTarget; | ||
| const defaultMessage = this.inputTarget.validationMessage; | ||
| let errorMessage; |
Contributor
Author
There was a problem hiding this comment.
more understandable code here
Member
|
closes #181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEFORE
AFTER
