Fix feature fiber storage#736
Merged
Merged
Conversation
This was referenced Jun 17, 2026
radar
approved these changes
Jun 17, 2026
Collaborator
|
Thanks! |
Merged
|
Would it be possible to consider yanking That also includes JRuby 9.4 which is only just in soft EOL now. |
|
Agree with the above on yanking, or perhaps fix a different way to allow 3.1? I have a number of apps and gems that need to support multiple Rubies, including Ruby 3.1, and with this change, Ruby 3.1 is just broken because 1.15.0 gets installed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #735.
Summary
i18n1.15.0 usesFiber[:i18n_config], butFiber.[]is only available starting from Ruby 3.2. The README already documents Ruby 3.2+ support, but the gemspec still allowed Ruby 3.1, which lets Bundler install a version that fails at runtime on Ruby 3.1.This PR updates the gemspec to require Ruby
>= 3.2and adds Ruby 3.2 back to the CI matrix so the minimum supported Ruby version is tested.Testing
I could not run the full test suite locally because my local Ruby is 3.1.7 and dependencies are not installed.
I verified locally that Ruby 3.1.7 does not support
Fiber.[]: