Add transliteration for O with ogonek#733
Merged
Merged
Conversation
Ǫ/ǫ (U+01EA/01EB) and Ǭ/ǭ (U+01EC/01ED) live in Latin Extended-B, which the default approximations table did not cover, so they transliterated to the replacement character "?" instead of "O"/"o". Fixes #732 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I18n.transliterate("CAIǪUE")returns"CAI?UE"instead of"CAIOUE".Ǫ/ǫ(U+01EA/01EB) andǬ/ǭ(U+01EC/01ED) are O-with-ogonek letters in the Latin Extended-B block. The defaultDEFAULT_APPROXIMATIONStable only covers Latin-1 Supplement and Latin Extended-A (up tož, U+017E), so these fall through to the replacement character?. This is inconsistent with e.g.Ų/ų(U+0172/0173), which sit in Extended-A and transliterate correctly toU/u.Fix
Add the four O-with-ogonek pairs to the table.
Fixes #732