Remove hidden attributes from required params #87
Conversation
numbata
left a comment
numbata
left a comment
There was a problem hiding this comment.
Thanks for the fix! I ran into this same issue yesterday and started working on a fix on the grape-swagger side as well. I think both fixes deserve to exist - yours handles it properly at the grape-swagger-entity side (where the root cause is), while the grape-swagger fix will act as a safeguard for similar issues that might come from other grape-swagger-* gems, not just grape-swagger-entity. Merging!
|
@bogdan Can you update CHANGELOG.md ? |
- Update `required_params` method to skip hidden attributes when determining required parameters. - Modify `response_model_spec` to reflect changes in required attributes, removing `hidden_attr`. - Add a test in `parser_spec` to ensure hidden attributes are not marked as required.
|
@dblock Hi! I found that the GitHub token hardcoded in the Danger workflows (in grape-swagger-entity and other grape repos) has expired. The token is returning |
|
@numbata I opened ruby-grape/grape#2630 with some details, feel free to pick it up! In the meantime removing danger or ignoring it is probably the easiest way, but I'd prefer a real fix. |
3 participants
After update to grape 3.0, hidden attributes started to appear inside required params. I am not sure why hidden parameters were not required when the same version of
grape-swagger-entitywas used with earlier versions ofgrape-swagger. But I think it requires a fix anyway.The bug was likely introduced here: b2a7b90
cc @numbata